>From Ali Alsuliman <[email protected]>:

Attention is currently required from: Ian Maxon, Hussain Towaileb.
Ali Alsuliman has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18373 )

Change subject: [ASTERIXDB-3429][EXT] Configurable CSV escape char
......................................................................


Patch Set 1:

(2 comments)

File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18373/comment/e32e9b21_c99e0f7d
PS1, Line 147: ExternalDataConstants.CSV_ESCAPE
I think this will depend on the format. If it is not CSV, then it should be 
ExternalDataConstants.ESCAPE. You can pass the format from the callers to here.


File 
hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FieldCursorForDelimitedDataParser.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18373/comment/5eae03f9_5c34387a
 
PS1, Line 69: double
escaped



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18373
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I50bebc4b8b683889855cb5dd048ab27d7c93af76
Gerrit-Change-Number: 18373
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-CC: Mehnaz Tabassum Mahin <[email protected]>
Gerrit-Attention: Ian Maxon <[email protected]>
Gerrit-Attention: Hussain Towaileb <[email protected]>
Gerrit-Comment-Date: Fri, 14 Jun 2024 15:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to