>From Wail Alkowaileet <[email protected]>: Attention is currently required from: Hussain Towaileb. Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443 )
Change subject: [NO ISSUE]: Avoid calling cloud to return list of all cached/uncached files ...................................................................... Patch Set 3: (5 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/AbstractCloudIOManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443/comment/c6156136_dfcb235e PS3, Line 377: listAsJson Maybe we should change this to list only uncached files? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443/comment/cf79f46c_95db207d PS3, Line 387: Files.size I'm worried to get failures as things get deleted. I.e., getting FileNotFoundException while trying to get the size. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443/comment/4ab224c2_61f9cf51 PS3, Line 391: // get uncached files : Set<CloudFile> uncached = new HashSet<>(); : for (UncachedFileReference uncachedFile : getUncachedFiles()) { : uncached.add(CloudFile.of(uncachedFile.getRelativePath(), uncachedFile.getSize())); : } : getUncachedFiles() already returns a new hashset. Just do: Set<CloudFile> uncached = getUncachedFiles() File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/ParallelCacher.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443/comment/5ecb3390_fd363ca2 PS3, Line 91: public make it synchronized https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443/comment/f8050d1e_cf1d5154 PS3, Line 97: uncached This one is already a copy -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I9f1dfa38a1aae986de7adbac283d126260606065 Gerrit-Change-Number: 18443 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2024 23:04:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
