>From Hussain Towaileb <[email protected]>: Attention is currently required from: Wail Alkowaileet. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443 )
Change subject: [NO ISSUE]: Avoid calling cloud to return list of all cached/uncached files ...................................................................... Patch Set 4: (5 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/AbstractCloudIOManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443/comment/cc115503_747d9334 PS3, Line 377: listAsJson > Maybe we should change this to list only uncached files? I made few changes in listing cached files, see if it handles the concerns please. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443/comment/e4eb6fa1_0d8fd2e5 PS3, Line 387: Files.size > I'm worried to get failures as things get deleted. I.e. […] I made few changes in listing cached files, see if it handles the concerns please. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443/comment/d56aaf27_e09a1b94 PS3, Line 391: // get uncached files : Set<CloudFile> uncached = new HashSet<>(); : for (UncachedFileReference uncachedFile : getUncachedFiles()) { : uncached.add(CloudFile.of(uncachedFile.getRelativePath(), uncachedFile.getSize())); : } : > getUncachedFiles() already returns a new hashset. Just do: […] getUncachedFiles returns a set of UncachedFileReference, this is just converting it into a set of cloud files to add all and sort. Or did I miss the ask here? File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/lazy/ParallelCacher.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443/comment/cb20923a_9ebb9a22 PS3, Line 91: public > make it synchronized Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443/comment/a2aa6f24_675f6625 PS3, Line 97: uncached > This one is already a copy Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I9f1dfa38a1aae986de7adbac283d126260606065 Gerrit-Change-Number: 18443 Gerrit-PatchSet: 4 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Attention: Wail Alkowaileet <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2024 05:58:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Gerrit-MessageType: comment
