>From Hussain Towaileb <[email protected]>: Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443 )
Change subject: [NO ISSUE]: Avoid calling cloud to return list of all cached/uncached files ...................................................................... Patch Set 6: Verified+1 Integration-Tests+1 (3 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/AbstractCloudIOManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443/comment/9d68e438_50e87ecb PS3, Line 377: listAsJson > I made few changes in listing cached files, see if it handles the concerns > please. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443/comment/093eba43_de3a21f3 PS3, Line 387: Files.size > I made few changes in listing cached files, see if it handles the concerns > please. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443/comment/77520734_64937a51 PS3, Line 391: // get uncached files : Set<CloudFile> uncached = new HashSet<>(); : for (UncachedFileReference uncachedFile : getUncachedFiles()) { : uncached.add(CloudFile.of(uncachedFile.getRelativePath(), uncachedFile.getSize())); : } : > getUncachedFiles returns a set of UncachedFileReference, this is just > converting it into a set of cl […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18443 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I9f1dfa38a1aae986de7adbac283d126260606065 Gerrit-Change-Number: 18443 Gerrit-PatchSet: 6 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2024 17:59:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Wail Alkowaileet <[email protected]> Comment-In-Reply-To: Hussain Towaileb <[email protected]> Gerrit-MessageType: comment
