>From Peeyush Gupta <[email protected]>: Attention is currently required from: Ali Alsuliman, Michael Blow, Hussain Towaileb. Peeyush Gupta has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19067 )
Change subject: [ASTERIXDB-3514][EXT]: Assume role only when temporary credentials expire ...................................................................... Patch Set 9: Code-Review+1 (1 comment) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalCredentialsCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19067/comment/19572e00_6bbf66df PS9, Line 64: String database = configuration.get(ExternalDataConstants.KEY_DATASET_DATABASE); : if (database == null) { : database = MetadataConstants.DEFAULT_DATABASE; : } : String dataverse = configuration.get(ExternalDataConstants.KEY_DATASET_DATAVERSE); : String dataset = configuration.get(ExternalDataConstants.KEY_DATASET); : return String.join(".", database, dataverse, dataset); Aren't the credentials per link? If yes, maybe we can cache the credentials per link. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19067 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I622853b794f81cd4bda84964a6cf7041d889d20f Gerrit-Change-Number: 19067 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Wed, 20 Nov 2024 21:57:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
