>From Murtadha Hubail <[email protected]>:

Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Michael 
Blow, Hussain Towaileb.
Murtadha Hubail has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19067 )

Change subject: [ASTERIXDB-3514][EXT]: Assume role only when temporary 
credentials expire
......................................................................


Patch Set 9: Code-Review+2

(1 comment)

File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalCredentialsCacheUpdater.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19067/comment/9f47e337_5999ba3c
PS9, Line 112: NCMessageBroker broker = (NCMessageBroker) 
appCtx.getServiceContext().getMessageBroker();
Let's discuss what happens when multiple NCs send this to the CC at some point



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19067
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I622853b794f81cd4bda84964a6cf7041d889d20f
Gerrit-Change-Number: 19067
Gerrit-PatchSet: 9
Gerrit-Owner: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-Attention: Peeyush Gupta <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Attention: Michael Blow <[email protected]>
Gerrit-Attention: Hussain Towaileb <[email protected]>
Gerrit-Comment-Date: Sat, 23 Nov 2024 15:37:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to