>From Hussain Towaileb <[email protected]>: Attention is currently required from: Peeyush Gupta, Ali Alsuliman, Michael Blow. Hussain Towaileb has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19067 )
Change subject: [ASTERIXDB-3514][EXT]: Assume role only when temporary credentials expire ...................................................................... Patch Set 9: (1 comment) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalCredentialsCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19067/comment/28c657a5_f569b4c5 PS9, Line 64: String database = configuration.get(ExternalDataConstants.KEY_DATASET_DATABASE); : if (database == null) { : database = MetadataConstants.DEFAULT_DATABASE; : } : String dataverse = configuration.get(ExternalDataConstants.KEY_DATASET_DATAVERSE); : String dataset = configuration.get(ExternalDataConstants.KEY_DATASET); : return String.join(".", database, dataverse, dataset); > Aren't the credentials per link? If yes, maybe we can cache the credentials > per link. It is per database.dataverse.dataset in open source, the getName is overridden by extension to use whatever entity they have. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19067 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I622853b794f81cd4bda84964a6cf7041d889d20f Gerrit-Change-Number: 19067 Gerrit-PatchSet: 9 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Thu, 21 Nov 2024 16:53:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peeyush Gupta <[email protected]> Gerrit-MessageType: comment
