>From Ritik Raj <[email protected]>: Attention is currently required from: Murtadha Hubail. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443 )
Change subject: [ASTERIXDB-3563][STO] Delay activation of dataset until accessed ...................................................................... Patch Set 3: (17 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/42b22d56_b8e54a3f PS2, Line 373: createDatasetLifecycleManager > we might not need this after addressing the comments Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/f3ddce68_9df7bc62 PS2, Line 74: ILocalResourceRepository > You can downcast here and just use it after concrete is not reachable here. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/d2a2c0fc_6cb1a215 PS2, Line 389: protected void validateDatasetLifecycleManagerState() throws HyracksDataException { > shouldn't need t his Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetResource.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/70f6180d_eb41ea11 PS2, Line 51: Map<Integer, Boolean> indexRecovered > Maybe use a set instead (recoveredPartitions) Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/0eb1f451_c9039e9d PS2, Line 132: areIndexesRecovered > isRecovered Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/b7943fa5_5e7c716e PS2, Line 148: setIndexRecovered > markRecovered or recovered Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/IRecoveryManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/ff812d7c_f5852344 PS2, Line 138: recoverIndexes > shouldn't need this after refactoring, seems it will be needed for calling the recovery logic from DatasetLifeCycleManager. File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/StoragePathUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/c3ef774c_3aa943db PS2, Line 144: rootSepIndex > better name? Done File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexDataflowHelper.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/5c0f9f8f_443c5648 PS2, Line 69: if (lcManager.resourceRecovered(resourceRef.getRelativePath())) { : lcManager.open(resourceRef.getRelativePath(), false); : } else { : // This will recover old index and also activated any new indexes. : lcManager.ensureIndexOpenAndConsistent(resourceRef.getRelativePath()); : } > revert this and do the recovery in open(. […] Done File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexLifecycleManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/5fff84e4_2ad6a9b2 PS2, Line 127: public boolean resourceRecovered(String resourcePath) throws HyracksDataException { : return true; : } > remove Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/209e191a_1837eacf PS2, Line 175: ensureIndexOpenAndConsistent > remove Done File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/48883078_6eabb8ad PS2, Line 196: // The only caller is LifeCycleManager.open(), so it seems nothing to worry about isActive check and fail. > make proper comment or remove Done File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/ILocalResourceRepository.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/d363645f_c2bd471d PS2, Line 37: getResources > You can cast this on asterixdb and remove it from the interface can't cast in DatasetLifeCycleManager, because the concrete implementation is unreachable. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/9b499992_b3064956 PS2, Line 42: IIOManager getIOManager(); > remove Done File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IResourceLifecycleManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/6c5d7322_53f48b8f PS2, Line 51: ensureIndexOpenAndConsistent > remove and just use open Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/4fd377f8_e0d90a1d PS2, Line 51: public void ens > java doc not applicable https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/5c63f1e1_d9adbdbc PS2, Line 60: resetStatsOnActivation > remove Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: If64a7fbd9701772ffa42761d1557223a3eea95be Gerrit-Change-Number: 19443 Gerrit-PatchSet: 3 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-CC: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Comment-Date: Fri, 28 Feb 2025 17:55:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]> Comment-In-Reply-To: Ritik Raj <[email protected]> Gerrit-MessageType: comment
