>From Murtadha Hubail <[email protected]>: Attention is currently required from: Ritik Raj. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443 )
Change subject: [ASTERIXDB-3563][STO] Delay activation of dataset until accessed ...................................................................... Patch Set 3: Code-Review+2 (3 comments) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/4f174e8c_ce104da0 PS3, Line 230: local dataset what's a local dataset? :) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/IRecoveryManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/ae5cfd87_61da5948 PS3, Line 134: r Ensures that {@code datasetPartitionIndexes} are consistent by performing component id level recovery File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IResourceLifecycleManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/ad6ce77e_ea0540f8 PS3, Line 50: Determines the resource opening behavior based on whether lazy recovery is enabled : * in the recovery manager. Maybe revert this as Hyracks doesn't know what a lazy recovery is -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: If64a7fbd9701772ffa42761d1557223a3eea95be Gerrit-Change-Number: 19443 Gerrit-PatchSet: 3 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Sun, 02 Mar 2025 13:19:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
