>From Ritik Raj <[email protected]>: Attention is currently required from: Murtadha Hubail. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443 )
Change subject: [ASTERIXDB-3563][STO] Delay activation of dataset until accessed ...................................................................... Patch Set 5: Verified+1 Code-Review+1 (8 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/d7d4c79d_e063364b PS2, Line 905: recoverIndexes > we probably don't need to add this to the interface Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/35bf3314_c7a32744 PS2, Line 74: ILocalResourceRepository > concrete is not reachable here. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/5cc39aa3_c80aad5d PS2, Line 209: , boolean resetStatsOnActivatio > we don't need this. Make the open call checks if it needs to recover the > index or not. […] Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/06142420_19d1d855 PS3, Line 230: local dataset > what's a local dataset? :) was referring to the partitions of the datasets present on the node, removing this as "local recovery" implies that. File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/IRecoveryManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/71f0bb42_cdae4cbd PS2, Line 138: recoverIndexes > after refactoring, seems it will be needed for calling the recovery logic > from DatasetLifeCycleManag […] Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/IRecoveryManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/8c642c9b_7df19201 PS3, Line 134: r > Ensures that {@code datasetPartitionIndexes} are consistent by performing > component id level recover […] Done File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/ILocalResourceRepository.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/5c1e449a_0046988d PS2, Line 37: getResources > can't cast in DatasetLifeCycleManager, because the concrete implementation is > unreachable. Done File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IResourceLifecycleManager.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443/comment/202fd29f_f8941850 PS3, Line 50: Determines the resource opening behavior based on whether lazy recovery is enabled : * in the recovery manager. > Maybe revert this as Hyracks doesn't know what a lazy recovery is Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/19443 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: If64a7fbd9701772ffa42761d1557223a3eea95be Gerrit-Change-Number: 19443 Gerrit-PatchSet: 5 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ritik Raj <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Comment-Date: Sun, 02 Mar 2025 20:29:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Murtadha Hubail <[email protected]> Comment-In-Reply-To: Ritik Raj <[email protected]> Gerrit-MessageType: comment
