>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Towaileb, Murtadha Hubail.
Michael Blow has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email ) Change subject: [ASTERIXDB-3659][EXT]: delegate assume role auth to AWS SDK ...................................................................... Patch Set 5: (6 comments) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/ac1890f5_aabba83c?usp=email : PS5, Line 63: AWS_ASSUME_ROLE_STALE_TIME( `STALE_TIME` mean something different than `CREDENTIALS_TTL`? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/d9379ead_f8f106c2?usp=email : PS5, Line 64: POSITIVE_INTEGER, isn't `0` a legal value, that it should always be refreshed? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/94ea9c96_3eee171d?usp=email : PS5, Line 70: "Time in seconds before the AWS assumed role credentials are considered close to stale and should be" I'm confused- if they're stale after 60s, how is 300s "close to stale"? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/9bfe6bc5_908ec21c?usp=email : PS5, Line 74: false, OOC- why do we default to false? File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/AwsUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/2faf8ead_f45b7c16?usp=email : PS3, Line 203: UUID.randomUUID().toString() > The session name is there just for logging purposes, ideally, I want it to be > the request id or job […] How do we collate this session name to the request? Should we be logging it? File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/AwsUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/4641b718_6241a8c2?usp=email : PS5, Line 335: } for L324-335, should we use one of those helpers that ensures a failure doesn't result in a leak? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I6a3c755f94d377b443f21594443fac830875610e Gerrit-Change-Number: 20493 Gerrit-PatchSet: 5 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Thu, 23 Oct 2025 00:59:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hussain Towaileb <[email protected]>
