>From Hussain Towaileb <[email protected]>:

Attention is currently required from: Michael Blow, Murtadha Hubail.

Hussain Towaileb has posted comments on this change by Hussain Towaileb. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email )

Change subject: [ASTERIXDB-3659][EXT]: delegate assume role auth to AWS SDK
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

File 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/AwsUtils.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493/comment/94da381e_7114e3b8?usp=email
 :
PS5, Line 335:         }
> By leak, do you mean the spammy log? If so, you're right, we should.
Edit
I should not close those silently, in case something important is logged during 
closing failure. Will just make sure that if closing fails, it will continue to 
close the others.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: phoenix
Gerrit-Change-Id: I6a3c755f94d377b443f21594443fac830875610e
Gerrit-Change-Number: 20493
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Michael Blow <[email protected]>
Gerrit-Comment-Date: Thu, 23 Oct 2025 16:38:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Michael Blow <[email protected]>
Comment-In-Reply-To: Hussain Towaileb <[email protected]>

Reply via email to