>From Hussain Towaileb <[email protected]>:
Attention is currently required from: Hussain Towaileb, Michael Blow, Murtadha
Hubail.
Hello Anon. E. Moose #1000171, Jenkins, Michael Blow, Murtadha Hubail,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Code-Review+1 by Hussain Towaileb, Integration-Tests+1 by Jenkins, Verified+1
by Jenkins, Verified-1 by Anon. E. Moose #1000171
Change subject: [ASTERIXDB-3659][EXT]: delegate assume role auth to AWS SDK
......................................................................
[ASTERIXDB-3659][EXT]: delegate assume role auth to AWS SDK
Details:
when using assume role authentication for AWS SDK,
we are using StsAssumeRoleCredentialsProvider, this
provider will refresh the assume role credentials
based on the provided configuration.
However, as this provider stays open and refreshes
itself, it requires the following:
- Closing this provider manually when done using it.
- STS client to talk to the STS service to assume role.
- Which in turn requires manual closing when done.
The method for building clients was changed to return
CloseableAwsClients which contains:
- Consuming client
This is the target client we are building, e.g., S3 client
or Glue client.
- STS client
This is the STS client used for talking with
STS service to assume the role.
- Credentials Provider
The credentials provider used for the consume client.
The above maintains a refrence for all clients and
credential providers so they all can be closed after
we are done using them.
Ext-ref: MB-68987
Change-Id: I6a3c755f94d377b443f21594443fac830875610e
---
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/cc/CcApplicationContext.java
D
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalCredentialsCache.java
D
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalCredentialsCacheUpdater.java
D
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/RefreshAwsCredentialsRequest.java
D
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/RefreshAwsCredentialsResponse.java
D
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/UpdateAwsCredentialsCacheRequest.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java
M
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1/cluster_state_1.1.regexadm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_full/cluster_state_1_full.1.regexadm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/api/cluster_state_1_less/cluster_state_1_less.1.regexadm
M
asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3CloudClient.java
M
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IApplicationContext.java
M
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
M asterixdb/asterix-external-data/pom.xml
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/aws/AwsS3InputStream.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/AwsUtils.java
A
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/glue/GlueUtils.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Constants.java
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/CleanupUtils.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/dataflow/LSMIndexCompactOperatorNodePushable.java
22 files changed, 343 insertions(+), 697 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/93/20493/7
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20493?usp=email
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: phoenix
Gerrit-Change-Id: I6a3c755f94d377b443f21594443fac830875610e
Gerrit-Change-Number: 20493
Gerrit-PatchSet: 7
Gerrit-Owner: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Michael Blow <[email protected]>
Gerrit-Attention: Hussain Towaileb <[email protected]>
