>From Ian Maxon <[email protected]>: Attention is currently required from: Suryaa Charan Shivakumar.
Ian Maxon has posted comments on this change by Suryaa Charan Shivakumar. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968?usp=email ) Change subject: [ASTERIXDB-3542] Added Coordinate Reference System support at Metadata and ST Transform function ...................................................................... Patch Set 5: (4 comments) File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/a2957e76_99cf51a0?usp=email : PS5, Line 1339: null shouldn't be null right? needs to be the namespace somehow? File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataCache.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/8fb3fd7d_2b48b51a?usp=email : PS5, Line 140: synchronized (synonyms) { as nauseating as this piece of code is, shouldn't there be a synchronized block here on crsMap? File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataTransactionContext.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/a118f627_5ecbc232?usp=email : PS5, Line 174: logAndApply why was the droppedCache::dropCrs call removed here? File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/IFunctionTypeInferer.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968/comment/e7f0ed30_ef2a7767?usp=email : PS5, Line 32: default void infer(ILogicalExpression expr, IFunctionDescriptor fd, IVariableTypeEnvironment context, : CompilerProperties compilerProps, Namespace defaultNamespace) throws AlgebricksException { : infer(expr, fd, context, compilerProps); what's this new signature for? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20968?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Ia6e37080a581292744ddc9020b214926412c16ac Gerrit-Change-Number: 20968 Gerrit-PatchSet: 5 Gerrit-Owner: Suryaa Charan Shivakumar <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Ian Maxon <[email protected]> Gerrit-Attention: Suryaa Charan Shivakumar <[email protected]> Gerrit-Comment-Date: Fri, 10 Apr 2026 16:51:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
