>From Preetham Poluparthi <[email protected]>: Attention is currently required from: Hussain Altowileb, Michael Blow.
Preetham Poluparthi has posted comments on this change by Preetham Poluparthi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277?usp=email ) Change subject: [ASTERIXDB-3768][CLOUD] Add S3 legacy MD5 and disable chunked encoding knobs ...................................................................... Patch Set 9: (4 comments) File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/05b8452d_d57f34d3?usp=email : PS6, Line 114: String endpoint = app.getString(CLOUD_STORAGE_ENDPOINT); : return endpoint != null && !endpoint.isEmpty(); > I think we should default this to false. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/dc426563_b9bf89b5?usp=email : PS6, Line 274: + " Defaults to true when a custom endpoint is configured, false for native AWS S3."; > I think we should default this to false. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/6251d455_298f922c?usp=email : PS6, Line 298: || this == CLOUD_STORAGE_S3_DISABLE_CHUNKED_ENCODING > ```suggestion […] Done File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Utils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/5597ab3b_73517ff0?usp=email : PS6, Line 211: builder.serviceConfiguration(S3Configuration.builder().chunkedEncodingEnabled(false).build()); > Sync'd offline w/ Hussain on this- we should add first-class configuration > parameters to S3 links fo […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I9443c9327a6bedb7e39c2ef1b729962b2237a974 Gerrit-Change-Number: 21277 Gerrit-PatchSet: 9 Gerrit-Owner: Preetham Poluparthi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Hussain Altowileb <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Hussain Altowileb <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Tue, 26 May 2026 17:39:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Blow <[email protected]>
