>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Altowileb, Preetham Poluparthi.
Michael Blow has posted comments on this change by Preetham Poluparthi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277?usp=email ) Change subject: [ASTERIXDB-3768][CLOUD] Add S3 legacy MD5 and disable chunked encoding knobs ...................................................................... Patch Set 9: (5 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ClientConfig.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/e7801bf6_468397b6?usp=email : PS9, Line 271: : public boolean isLegacyMd5Checksum() { : return legacyMd5Checksum; : } : : public boolean isDisableChunkedEncoding() { : return disableChunkedEncoding; : } NIT: move above toString() File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/93d16976_cfd4e776?usp=email : PS9, Line 109: (Function<IApplicationConfig, Boolean>) app -> { : String endpoint = app.getString(CLOUD_STORAGE_ENDPOINT); : return endpoint != null && !endpoint.isEmpty(); : } per latest discussions with @[email protected], I think we can safely default this to `false`. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/758d4916_4f93631d?usp=email : PS9, Line 265: OCI Object Storage We should probably be more formal ```suggestion + " Required for S3-compatible storage (e.g. Oracle Cloud Infrastructure Object Storage) that expects" ``` https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/0766f564_1f214149?usp=email : PS9, Line 267: true when a custom endpoint is configured, false for native AWS S3 ```suggestion + " Defaults to false."; ``` https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/e232fbd3_aff6c1d6?usp=email : PS9, Line 295: if (this == CLOUD_STORAGE_S3_LEGACY_MD5_CHECKSUM) { : return "true if a custom endpoint is set; false otherwise"; : } remove? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I9443c9327a6bedb7e39c2ef1b729962b2237a974 Gerrit-Change-Number: 21277 Gerrit-PatchSet: 9 Gerrit-Owner: Preetham Poluparthi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Hussain Altowileb <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Hussain Altowileb <[email protected]> Gerrit-Attention: Preetham Poluparthi <[email protected]> Gerrit-Comment-Date: Tue, 26 May 2026 19:25:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
