>From Preetham Poluparthi <[email protected]>: Attention is currently required from: Hussain Altowileb, Michael Blow.
Preetham Poluparthi has posted comments on this change by Preetham Poluparthi. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277?usp=email ) Change subject: [ASTERIXDB-3768][CLOUD] Add S3 legacy MD5 and disable chunked encoding knobs ...................................................................... Patch Set 11: (5 comments) File asterixdb/asterix-cloud/src/main/java/org/apache/asterix/cloud/clients/aws/s3/S3ClientConfig.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/8aa7a907_9a71357e?usp=email : PS9, Line 271: : public boolean isLegacyMd5Checksum() { : return legacyMd5Checksum; : } : : public boolean isDisableChunkedEncoding() { : return disableChunkedEncoding; : } > NIT: move above toString() Done File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/CloudProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/c4002e2e_ce1d5e8e?usp=email : PS9, Line 109: (Function<IApplicationConfig, Boolean>) app -> { : String endpoint = app.getString(CLOUD_STORAGE_ENDPOINT); : return endpoint != null && !endpoint.isEmpty(); : } > per latest discussions with @[email protected], I think we can safely > default this to `false`. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/5babcf92_539b0aaa?usp=email : PS9, Line 265: OCI Object Storage > We should probably be more formal […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/b44c7ae3_fac3983e?usp=email : PS9, Line 267: true when a custom endpoint is configured, false for native AWS S3 > ```suggestion […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277/comment/3e7f68d8_1fb59e27?usp=email : PS9, Line 295: if (this == CLOUD_STORAGE_S3_LEGACY_MD5_CHECKSUM) { : return "true if a custom endpoint is set; false otherwise"; : } > remove? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21277?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: lumina Gerrit-Change-Id: I9443c9327a6bedb7e39c2ef1b729962b2237a974 Gerrit-Change-Number: 21277 Gerrit-PatchSet: 11 Gerrit-Owner: Preetham Poluparthi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Hussain Altowileb <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Hussain Altowileb <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Tue, 26 May 2026 19:43:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Blow <[email protected]>
