Yingyi Bu has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index ......................................................................
Patch Set 6: (2 comments) It looks the property "antimatter" (more precisely, "isDelete") should be factored out from TupleWriter and TupleWriterFactory. It is a property of a tuple that we're writing rather than a property of the writer. https://asterix-gerrit.ics.uci.edu/#/c/1796/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java: PS6, Line 88: setAntimatter I think the abstraction was not right. isAntimatter is a property of the tuple that we're writing, but not a property of the Writer. Hence, we probably should remove setAntimatter(...) from the TupleWriter. Instead, we add a parameter to write tuple method: public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff) -> public int writeTuple(ITupleReference tuple, byte[] targetBuf, int targetOff, boolean isDelete) https://asterix-gerrit.ics.uci.edu/#/c/1796/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentBulkLoader.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentBulkLoader.java: PS6, Line 119: updateFilter Should updateFilter(...) behave differently for add(..) and delete(...)? I don't think a delete operation can affect the existing filter? -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
