Ian Maxon has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index ......................................................................
Patch Set 6: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1796/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java: PS5, Line 32: isAntima > Across code base, I saw some places use isAntimatter (like here), and some Well, maybe it's a bias, but I think antimatter is a more orthogonal term for the behavior. A 'delete' tuple can lead to confusing phrases. https://asterix-gerrit.ics.uci.edu/#/c/1796/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentBulkLoader.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentBulkLoader.java: PS6, Line 119: updateFilter > Should updateFilter(...) behave differently for add(..) and delete(...)? I think it has to. You have to search for the antimatter just as you would a matter tuple. You wouldn't want the filter to restrict it from being found. https://asterix-gerrit.ics.uci.edu/#/c/1796/5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentWithBuddyBulkLoader.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentWithBuddyBulkLoader.java: PS5, Line 87: : updateFilter(tuple) > Currently, when we delete a tuple (insert antimatter tuple or insert into t Ah, right, that makes sense now that I think about it more. One needs to search for the antimatter tuple as part of the filtered query. -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
