Luo Chen has posted comments on this change. Change subject: Allow insert anti-matter tuples when bulk loading LSM index ......................................................................
Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1796/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/tuples/LSMBTreeTupleWriter.java: PS6, Line 88: setAntimatter > I think the abstraction was not right. This makes sense. However, adding this method would make a lot of changes to the existing LSM indexes. Take BTree (and LSMBTree) as an example. Anti-matter tuple is only a special property for LSMBTree, but not BTree. When we insert a tuple (matter or anti-matter) into a LSMBTree, we first choose a proper leaf frame of BTree (insertLeafFrame or deleteLeafFrame), and let the BTree to do the actual insert based on that frame. Adding this method would totally change this workflow, since BTree now has to know whether it's a anti-matter tuple or not. I would suggest maybe we can make this refactoring as a separate patch? -- To view, visit https://asterix-gerrit.ics.uci.edu/1796 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6665f56a5d2183697197298fa24824eeb827686a Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
