abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2184] Add Immutable DiskBTree ......................................................................
Patch Set 9: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2193/9/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeRangeSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeRangeSearchCursor.java: PS9, Line 110: releasePage(); : page = acquirePage(nextLeafPage); before, we used to acquire locks before releasing current page. Should we maintain that? What are the implications? What if between releasing this one and acquiring the next one, the next leaf pointer changes and the next page is not the same anymore? -- To view, visit https://asterix-gerrit.ics.uci.edu/2193 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f2a9281478c4b8665589dc695769d0497af9961 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
