Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-2184] Add Immutable DiskBTree ......................................................................
Patch Set 9: (2 comments) > (1 comment) > > The logger stuff also needs to be updated to use Log4j2 Done. https://asterix-gerrit.ics.uci.edu/#/c/2193/8/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeRangeSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeRangeSearchCursor.java: PS8, Line 221: resetBeforeOpen(); > Why close() here?... This should be similar to reset() here, which internally calls close(). But in order not to cause confusions, I changed resetBeforeOpen() to only release the current page. https://asterix-gerrit.ics.uci.edu/#/c/2193/9/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeRangeSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/impls/BTreeRangeSearchCursor.java: PS9, Line 110: releasePage(); : page = acquirePage(nextLeafPage); > before, we used to acquire locks before releasing current page. I see. I modified this change to first acquireNextLeaf, and then release the current page. -- To view, visit https://asterix-gerrit.ics.uci.edu/2193 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f2a9281478c4b8665589dc695769d0497af9961 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
