Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-2184] Add Immutable DiskBTree ......................................................................
Patch Set 9: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2193/8/hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/frames/BTreeNSMLeafFrame.java File hyracks-fullstack/hyracks/hyracks-storage-am-btree/src/main/java/org/apache/hyracks/storage/am/btree/frames/BTreeNSMLeafFrame.java: PS8, Line 347: @Override : public ITupleReference getLeftmostTuple() { : int tupleCount = getTupleCount(); : if (tupleCount == 0) { : return null; : } else { : frameTuple.resetByTupleIndex(this, 0); : return frameTuple; : } : } : : @Override : public ITupleReference getRightmostTuple() { : int tupleCount = getTupleCount(); : if (tupleCount == 0) { : return null; : } else { : frameTuple.resetByTupleIndex(this, tupleCount - 1); : return frameTuple; : } : } > these are exactly like the one in BTreeNSMInteriorFrame. I moved this two methods to ITreeIndexFrame, since it seems natural for a frame (as a list of fields) to provide such APIs. Or, they could also be moved to DiskBTree, since it's the only place right now which uses these two methods. -- To view, visit https://asterix-gerrit.ics.uci.edu/2193 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f2a9281478c4b8665589dc695769d0497af9961 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
