Preston Carman has posted comments on this change.

Change subject: Convert comparisons with current-datetime, current-date, and 
current-time to applicable index searches as though they were constants
......................................................................


Patch Set 1:

(1 comment)

I wish there was a cleaner way to add this functionality. My only comment is on 
the algebricks function name update.

https://asterix-gerrit.ics.uci.edu/#/c/367/1/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AsterixInlineVariablesRule.java
File 
asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/AsterixInlineVariablesRule.java:

Line 43:         return AccessMethodUtils.exprCreatesConstant(expr).first;
function name idea: isFunctionResultConstant()


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/367
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied64276873afcfbdd31dac313009e47429d8f9b0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Preston Carman <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-HasComments: Yes

Reply via email to