Yingyi Bu has posted comments on this change.
Change subject: Convert comparisons with current-datetime, current-date, and
current-time to applicable index searches as though they were constants
......................................................................
Patch Set 1:
IMO, if a user type the following query:
for $emergency in dataset CHPReports
where $emergency.timestamp >= current-datetime() - day-time-duration("PT10H")
return $emergency.message;
"current-datetime()" might just mean the time s/he submits this query to
AsterixDB. If so, compile-time constant might be a better approximate since we
currently don't do any plan caching thing...
Are there any cases that strictly require execution time current-time()?
Also, could the recognition of a function expression as a constant be more
general than checking particular function identifiers in AccessMethodUtils?
A function expression is a constant if it doesn't have any parameter that is a
variable reference expression in its expression tree, right?
--
To view, visit https://asterix-gerrit.ics.uci.edu/367
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied64276873afcfbdd31dac313009e47429d8f9b0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Preston Carman <[email protected]>
Gerrit-Reviewer: Steven Jacobs <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-HasComments: No
