Yingyi Bu has posted comments on this change. Change subject: Convert comparisons with current-datetime, current-date, and current-time to applicable index searches as though they were constants ......................................................................
Patch Set 1: (1 comment) I wonder would it be better that the ConstantFoldingRule can deal with it? It seems to me that AccessMethodUtils could keep un-aware of those particular functions, etc. I guess an alternative approach is to add one rewrite rule to replace current-datetime(), current-date(), and current-time() calls with constant values. Then, the access methods related things can stay unchanged. Am I right? https://asterix-gerrit.ics.uci.edu/#/c/367/1/asterix-app/src/test/resources/optimizerts/queries/btree-index/btree-datetime-03.aql File asterix-app/src/test/resources/optimizerts/queries/btree-index/btree-datetime-03.aql: Line 22: where $emergency.timestamp >= current-datetime() trim space. -- To view, visit https://asterix-gerrit.ics.uci.edu/367 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied64276873afcfbdd31dac313009e47429d8f9b0 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
