[
https://issues.apache.org/jira/browse/COUCHDB-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158834#comment-15158834
]
ASF subversion and git services commented on COUCHDB-2943:
----------------------------------------------------------
Commit 40d956f0787087f47332e11e40f4b65cc9d0ce4a in couchdb-fauxton's branch
refs/heads/master from [~robertkowalski]
[ https://git-wip-us.apache.org/repos/asf?p=couchdb-fauxton.git;h=40d956f ]
trays: use higher order components to connect them to stores
this is the first step to get rid of <Tray /> which uses
`FauxtonAPI.Events` and additionally manages its own state by
accessing the DOM which leads to subtle bugs.
we use composition/higher order components as all trays share the
same wrapper, but have different stores connected.
- change test urls to example.com, which is reserved for testing
- use React.findDOMNode
- trays don't touch the DOM directly any more
COUCHDB-2943
PR: #642
PR-URL: https://github.com/apache/couchdb-fauxton/pull/642
Reviewed-By: Benjamin Keen <[email protected]>
> Tray Refactor & Bugfix: does not close after querying
> -----------------------------------------------------
>
> Key: COUCHDB-2943
> URL: https://issues.apache.org/jira/browse/COUCHDB-2943
> Project: CouchDB
> Issue Type: Bug
> Components: Fauxton
> Reporter: Robert Kowalski
>
> When opening the Options Tray in the all_docs view, clicking query and then
> cancel, clicking Cancel in the Query Options panel doesn't close it.
> The root problem is the global event bus used by the parent Tray component
> which is registering the event listener two times.
> The Tray needs to use an Action and a Store and follow the Flux model instead
> of global events and event listeners in mount/unmount
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
