[
https://issues.apache.org/jira/browse/COUCHDB-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159145#comment-15159145
]
ASF GitHub Bot commented on COUCHDB-2943:
-----------------------------------------
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/654
Trays: finish softmigration
Fix bug where the query panel stayed open after multiple clicks:
When opening the Options Tray in the all_docs view, clicking query
and then cancel, clicking Cancel in the Query Options panel
doesn't close it.
uses flux for state management of the tray.
closes COUCHDB-2943
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton tary
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/654.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #654
----
commit 6094b52f828e3e6831eb0d027bb27601dc678c55
Author: Robert Kowalski <[email protected]>
Date: 2016-02-23T13:46:28Z
Trays: finish softmigration
Fix bug where the query panel stayed open after multiple clicks:
When opening the Options Tray in the all_docs view, clicking query
and then cancel, clicking Cancel in the Query Options panel
doesn't close it.
uses flux for state management of the tray.
closes COUCHDB-2943
----
> Tray Refactor & Bugfix: does not close after querying
> -----------------------------------------------------
>
> Key: COUCHDB-2943
> URL: https://issues.apache.org/jira/browse/COUCHDB-2943
> Project: CouchDB
> Issue Type: Bug
> Components: Fauxton
> Reporter: Robert Kowalski
>
> When opening the Options Tray in the all_docs view, clicking query and then
> cancel, clicking Cancel in the Query Options panel doesn't close it.
> The root problem is the global event bus used by the parent Tray component
> which is registering the event listener two times.
> The Tray needs to use an Action and a Store and follow the Flux model instead
> of global events and event listeners in mount/unmount
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
