[
https://issues.apache.org/jira/browse/COUCHDB-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139286#comment-15139286
]
ASF GitHub Bot commented on COUCHDB-2943:
-----------------------------------------
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/642
trays: use higher order components to connect them to stores
this is the first step to get rid of `<Tray />` which uses
`FauxtonAPI.Events` and additionally manages its own state by
accessing the DOM which leads to subtle bugs.
we use composition/higher order components as all trays share the
same wrapper, but have different stores connected.
- change test urls to example.com, which is reserved for testing
- use React.findDOMNode
- trays don't touch the DOM directly any more
COUCHDB-2943
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton
trays-composition
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/642.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #642
----
commit 7200dce0418ba71dbac08263c2691b7a40ce2726
Author: Robert Kowalski <[email protected]>
Date: 2016-02-09T17:39:55Z
trays: use higher order components to connect them to stores
this is the first step to get rid of <Tray /> which uses
`FauxtonAPI.Events` and additionally manages its own state by
accessing the DOM which leads to subtle bugs.
we use composition/higher order components as all trays share the
same wrapper, but have different stores connected.
- change test urls to example.com, which is reserved for testing
- use React.findDOMNode
- trays don't touch the DOM directly any more
COUCHDB-2943
----
> Tray Refactor & Bugfix: does not close after querying
> -----------------------------------------------------
>
> Key: COUCHDB-2943
> URL: https://issues.apache.org/jira/browse/COUCHDB-2943
> Project: CouchDB
> Issue Type: Bug
> Components: Fauxton
> Reporter: Robert Kowalski
>
> When opening the Options Tray in the all_docs view, clicking query and then
> cancel, clicking Cancel in the Query Options panel doesn't close it.
> The root problem is the global event bus used by the parent Tray component
> which is registering the event listener two times.
> The Tray needs to use an Action and a Store and follow the Flux model instead
> of global events and event listeners in mount/unmount
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
