iilyak commented on a change in pull request #496: Couchdb 3287 pluggable 
storage engines
URL: https://github.com/apache/couchdb/pull/496#discussion_r114632152
 
 

 ##########
 File path: src/couch/test/couch_stream_tests.erl
 ##########
 @@ -14,10 +14,11 @@
 
 -include_lib("couch/include/couch_eunit.hrl").
 
+-define(ENGINE, {couch_bt_engine_stream, {Fd, []}}).
 
 Review comment:
   The variable name is hard-coded in a define. Could we do something about it? 
For example:
   
   `-define(ENGINE(Var), {couch_bt_engine_stream, {Var, []}}).`
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to