iilyak commented on a change in pull request #496: Couchdb 3287 pluggable
storage engines
URL: https://github.com/apache/couchdb/pull/496#discussion_r114888556
##########
File path: src/couch_mrview/src/couch_mrview_util.erl
##########
@@ -236,7 +237,9 @@ init_state(Db, Fd, State, Header) ->
view_states=ViewStates
} = Header,
- IdBtOpts = [{compression, couch_db:compression(Db)}],
+ IdBtOpts = [
+ {compression, couch_compress:get_compression_method()}
Review comment:
This would work since old implementation calls to
`couch_compress:get_compression_methods()` from `couch_db_updater:init_db`.
However this would mean that we wouldn't be able to support different
compression methods for different databases. Also it wouldn't be possible to
delegate the decision on a compression algorithm to the storage engine (if we
are not dispatching through `couch_engine`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
