iilyak commented on a change in pull request #496: Couchdb 3287 pluggable
storage engines
URL: https://github.com/apache/couchdb/pull/496#discussion_r114674271
##########
File path: src/couch/src/couch_util.erl
##########
@@ -62,6 +63,37 @@ normparts(["." | RestParts], Acc) ->
normparts([Part | RestParts], Acc) ->
normparts(RestParts, [Part | Acc]).
+
Review comment:
This looks very similar to
https://github.com/erlang/otp/blob/master/lib/stdlib/src/filelib.erl#L103. Is
there a reason to write own implementation? filelib's implementation considered
slow (based on info from erlang mailing list) due to use of regexp. However
this implementation uses it as well.
I'll read through the implementation some more tomorrow (maybe there is a
reason).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
