[GitHub] [couchdb] davisp commented on a change in pull request #2585: Mango Indexes on FoundationDB

[GitBox]

davisp commented on a change in pull request #2585: Mango Indexes on 
FoundationDB
URL: https://github.com/apache/couchdb/pull/2585#discussion_r393759505
 
 

 ##########
 File path: src/mango/src/mango_cursor.erl
 ##########
 @@ -104,7 +106,7 @@ filter_indexes(Indexes, DesignId0) ->
         Else ->
             <<"_design/", Else/binary>>
     end,
-    FiltFun = fun(I) -> mango_idx:ddoc(I) == DesignId end,
 
 Review comment:
   What's with this ddoc -> ddoc_id change? Its purely cosmetic right? I'm not 
against the change but it should be extracted into its own PR. Mixing style and 
logic changes in PRs makes for Bad Times &trade;.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services