davisp commented on a change in pull request #2585: Mango Indexes on 
FoundationDB
URL: https://github.com/apache/couchdb/pull/2585#discussion_r393760564
 
 

 ##########
 File path: src/mango/src/mango_cursor.erl
 ##########
 @@ -206,12 +214,9 @@ invalid_index_warning_int(_, _) ->
 % returned, implying a lot of in-memory filtering
 index_scan_warning(#execution_stats {
                     totalDocsExamined = Docs,
-                    totalQuorumDocsExamined = DocsQuorum,
 
 Review comment:
   The quorum docs stat and the r/w removal should probably be moved to their 
own commits. They make sense after remembering that its FDB now but its easy to 
forget/miss the reason for the change with it not being called out explicitly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to