davisp commented on a change in pull request #2585: Mango Indexes on 
FoundationDB
URL: https://github.com/apache/couchdb/pull/2585#discussion_r393743492
 
 

 ##########
 File path: src/couch_views/src/couch_views_indexer.erl
 ##########
 @@ -159,28 +156,17 @@ update(#{} = Db, Mrst0, State0) ->
     {Mrst2, State4} = fabric2_fdb:transactional(Db, fun(TxDb) ->
         % In the first iteration of update we need
         % to populate our db and view sequences
 
 Review comment:
   You should move this comment to the function head where we guard on 
`#{db_seq := undefined}` so the comment explains the logic where it exists.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to