willholley commented on PR #4512:
URL: https://github.com/apache/couchdb/pull/4512#issuecomment-1503590378

   @pgj those performance numbers look very promising! I think this looks 
mostly good from an implementation perspective, though I'll leave others to 
comment on the Erlang style. One thing that's missing though is handling 
`execution_stats`. The `execution_stats` object anticipated covering indexes in 
its structure:
   
   ```
   "execution_stats": {
           "total_keys_examined": 0,
           "total_docs_examined": 200,
           "total_quorum_docs_examined": 0,
           "results_returned": 2,
           "execution_time_ms": 5.52
       }
   ```
   
   `total_keys_examined` has not been meaningful until now, and I'd expect it 
to equal the number of keys read to service the query, where for non-covering 
indexes this is returned in the `total_docs_examined` field.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to