pgj commented on code in PR #4512:
URL: https://github.com/apache/couchdb/pull/4512#discussion_r1167318310
##########
src/mango/src/mango_idx_view.erl:
##########
@@ -26,14 +26,20 @@
indexable_fields/1,
field_ranges/1,
- field_ranges/2
+ field_ranges/2,
+
+ covers/2
]).
-include_lib("couch/include/couch_db.hrl").
-include("mango.hrl").
-include("mango_idx.hrl").
-include("mango_idx_view.hrl").
+-ifdef(TEST).
+-import(test_util, [as_selector/1]).
+-endif.
+
Review Comment:
The purpose of this `import` is to be able to share the
`test_util:as_selector/1` function between multiple modules. Initially, I
added almost the same definition for multiple modules and then I merged them
into a single one and placed in `test_util`. Or are you talking about a local
alias for `test_util:as_selector/1`? In that case, it would not be that much
of a gain, because its (proposed) name would not be that much shorter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
