nickva commented on code in PR #4512:
URL: https://github.com/apache/couchdb/pull/4512#discussion_r1167030830
##########
src/mango/src/mango_cursor_view.erl:
##########
@@ -482,6 +564,32 @@ apply_opts([{_, _} | Rest], Args) ->
% Ignore unknown options
apply_opts(Rest, Args).
+-spec consider_index_coverage(#idx{}, fields(), #mrargs{}) -> #mrargs{}.
+consider_index_coverage(Index, Fields, #mrargs{include_docs = IncludeDocs} =
Args) ->
Review Comment:
I had noticed that we always call `apply_opts` then right after always call
`consider_index_coverage`. It might make sense to have a function like
`apply_cursor_opts` which then may still call `apply_opts` and
`consider_index_coverage`. We'd keep both since both are tested separately they
can stay that way to minimize the changes diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
