rnewson opened a new pull request, #4798: URL: https://github.com/apache/couchdb/pull/4798
## Overview To smooth cluster upgrades, send the original format of AuthSession cookie if MustMatchBasic is false (i.e, when generating a Cookie from a successful cookie_auth_handler call). Prior to this (and after 50c69a0c68), during an upgrade, a cookie issued by the basic auth handler from an upgraded node will not be parseable by not-upgraded nodes. With this change a cookie issued by the cookie_auth_handler retains its original format. Only cookies issued by the default_auth_handler will be the new format. ## Testing recommendations 1) Create a mixed state cluster (with a node on code before https://github.com/apache/couchdb/pull/4702 and other nodes with this code or later). 2) acquire a cookie from new node via `/_session` 3) present the cookie to an old node. 4) cookie should be accepted. ## Related Issues or Pull Requests https://github.com/apache/couchdb/pull/4702 ## Checklist - [x] Code is written and works correctly - [ ] Changes are covered by tests - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini` - [ ] Documentation changes were made in the `src/docs` folder - [ ] Documentation changes were backported (separated PR) to affected branches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
