jiahuili430 commented on code in PR #4798: URL: https://github.com/apache/couchdb/pull/4798#discussion_r1347496134
########## src/couch/src/couch_httpd_auth.erl: ########## @@ -460,16 +460,17 @@ cookie_auth_header( cookie_auth_header(_Req, _Headers) -> []. -cookie_auth_cookie(Req, User, Secret, TimeStamp, MustMatchBasic) -> - MustMatchBasicStr = - case MustMatchBasic of - true -> "1"; - false -> "0" - end, +cookie_auth_cookie(Req, User, Secret, TimeStamp, true) -> SessionData = lists:join(":", [ User, - lists:join(",", [erlang:integer_to_list(TimeStamp, 16), MustMatchBasicStr]) + lists:join(",", [erlang:integer_to_list(TimeStamp, 16), "1"]) ]), + cookie_auth_cookie(Req, Secret, SessionData); +cookie_auth_cookie(Req, User, Secret, TimeStamp, false) -> + SessionData = ?b2l(User) ++ ":" ++ erlang:integer_to_list(TimeStamp, 16), Review Comment: Probably because of https://github.com/apache/couchdb/commit/50c69a0c685c86774e18c91ee67b3c3a64404370#diff-435e77c8738bbe08e5266d5e146e8857f3cc7676be821a12f977f0aa87d43b7eL415? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@couchdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org