rnewson commented on code in PR #4798:
URL: https://github.com/apache/couchdb/pull/4798#discussion_r1347497366
##########
src/couch/src/couch_httpd_auth.erl:
##########
@@ -460,16 +460,17 @@ cookie_auth_header(
cookie_auth_header(_Req, _Headers) ->
[].
-cookie_auth_cookie(Req, User, Secret, TimeStamp, MustMatchBasic) ->
- MustMatchBasicStr =
- case MustMatchBasic of
- true -> "1";
- false -> "0"
- end,
+cookie_auth_cookie(Req, User, Secret, TimeStamp, true) ->
SessionData = lists:join(":", [
User,
- lists:join(",", [erlang:integer_to_list(TimeStamp, 16),
MustMatchBasicStr])
+ lists:join(",", [erlang:integer_to_list(TimeStamp, 16), "1"])
]),
+ cookie_auth_cookie(Req, Secret, SessionData);
+cookie_auth_cookie(Req, User, Secret, TimeStamp, false) ->
+ SessionData = ?b2l(User) ++ ":" ++ erlang:integer_to_list(TimeStamp, 16),
Review Comment:
because the earlier PR removed some unnecessary b2l/l2b code, and this
partially reverses it.
but now I look at I think I prefer `SessionData = lists:join(":", [User,
erlang:integer_to_list(TimeStamp, 16)]),` for the old cookie generation.
cleaner that way and matches the new clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
