willholley commented on code in PR #4810:
URL: https://github.com/apache/couchdb/pull/4810#discussion_r1363693652


##########
src/mango/src/mango_selector.erl:
##########
@@ -1054,4 +1061,29 @@ fields_nor_test() ->
     },
     ?assertEqual([<<"field1">>, <<"field2">>], fields_of(Selector2)).
 
+match_beginswith_test() ->
+    Doc =
+        {[
+            {<<"_id">>, <<"foo">>},
+            {<<"_rev">>, <<"bar">>},
+            {<<"user_id">>, 11}
+        ]},
+    Check = fun(Field, Prefix) ->

Review Comment:
   the `Check` function is test-specific so I'm not convinced it makes sense to 
share it. I don't think `match_demo_test_` is actually running any tests (this 
confused me for a while but note it calls `?_assertEqual` instead of 
`?assertEqual` which appears to be a no-op.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to