pgj commented on code in PR #4810: URL: https://github.com/apache/couchdb/pull/4810#discussion_r1367715142
########## src/mango/test/25-beginswith-test.py: ########## @@ -0,0 +1,112 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); you may not +# use this file except in compliance with the License. You may obtain a copy of +# the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations under +# the License. + +import copy +import mango + +DOCS = [ + {"_id": "aaa", "name": "Jimi", "location": "AUS", "age": 27}, + {"_id": "abc", "name": "Eddie", "location": "AND", "age": 65}, + {"_id": "bbb", "name": "Harry", "location": "CAN", "age": 21}, + {"_id": "ccc", "name": "Eddie", "location": "DEN", "age": 37}, + {"_id": "ddd", "name": "Jones", "location": "ETH", "age": 49}, +] + + +def to_utf8_bytes(list): + return [x.encode() for x in list] + + +class BeginsWithOperator(mango.DbPerClass): + def setUp(self): + self.db.recreate() + self.db.save_docs(copy.deepcopy(DOCS)) + self.db.create_index(["location"]) + self.db.create_index(["name", "location"]) + + def assertDocIds(self, user_ids, docs): + user_ids_returned = list(d["_id"] for d in docs) + user_ids.sort() + user_ids_returned.sort() + self.assertEqual(user_ids, user_ids_returned) + + def test_basic(self): + docs = self.db.find({"location": {"$beginsWith": "A"}}) + + self.assertEqual(len(docs), 2) + self.assertDocIds(["aaa", "abc"], docs) + + def test_json_range(self): + explain = self.db.find({"location": {"$beginsWith": "A"}}, explain=True) + self.assertEqual(explain["mrargs"]["start_key"], ["A"]) Review Comment: @willholley are you planning to modify the code according this suggestion? I am only asking because I saw that you sent a "thumbs up" reaction but there was no associated change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
