pgj commented on code in PR #4810:
URL: https://github.com/apache/couchdb/pull/4810#discussion_r1367714649
##########
src/mango/src/mango_selector.erl:
##########
@@ -1054,4 +1061,29 @@ fields_nor_test() ->
},
?assertEqual([<<"field1">>, <<"field2">>], fields_of(Selector2)).
+match_beginswith_test() ->
+ Doc =
+ {[
+ {<<"_id">>, <<"foo">>},
+ {<<"_rev">>, <<"bar">>},
+ {<<"user_id">>, 11}
+ ]},
+ Check = fun(Field, Prefix) ->
Review Comment:
@willholley ah, I see -- I got probably mislead by the comment that was
copied over from the other similarly-looking definition. On the other hand, I
tend to agree with @nickva regarding the actual definition itself. Embedding
the use of `Doc` variable internally makes the test cases a bit less explicit
and hard to follow. I am aware that this is coming from the other test case
but perhaps we could cha(lle)nge the original structure here.
With regard to the no-op test case, maybe this is the time to either fix or
scratch it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
