witash commented on PR #6138: URL: https://github.com/apache/couchdb/pull/6138#issuecomment-5907913335
> The way nouveau purges is modelled on dreyfus which is modelled on mrview (the original index) so I've a mild preference for retaining the basic shape. Looking at the mrview code in `src/couch_index/src/couch_index_updater.erl`, this branch is actually closer to the mrview shape, where the purge phase only removes documents from the index, and the changes phase re-adds the ones that still exist. That's also why this branch uses `make_purge` when a document still exists and its seq is greater than the index's update_seq from the start of the update. It might be simpler to do nothing for purge infos whose document is still in the database, but removing it and letting the changes phase re-add it is closer to what mrview does. This branch is now more different from dreyfus, but the key difference with dreyfus is that index updates don't include a sequence, so it can re-index documents during the purge phase without any sequence problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
