Alanxtl commented on code in PR #2906: URL: https://github.com/apache/dubbo-go/pull/2906#discussion_r2119037311
########## filter/graceful_shutdown/compat.go: ########## Review Comment: actually what I've done are: - delete `graceful_shutdown/compat.go` because the func is identically the same as `compatShutdownConfig` declared in `compat.go` - add `compatGlobalShutdownConfig` in `filter/graceful_shutdown/compat.go` because I changed `shutdownConfig *config.ShutdownConfig` to `shutdownConfig *global.ShutdownConfig` in `filter/graceful_shutdown/provider_filter.go`, I need a function to convert `*config.ShutdownConfig` to `*global.ShutdownConfig` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
