AlexStocks commented on code in PR #2906:
URL: https://github.com/apache/dubbo-go/pull/2906#discussion_r2119964030
##########
filter/graceful_shutdown/consumer_filter.go:
##########
@@ -76,11 +77,15 @@ func (f *consumerGracefulShutdownFilter) OnResponse(ctx
context.Context, result
func (f *consumerGracefulShutdownFilter) Set(name string, conf any) {
switch name {
case constant.GracefulShutdownFilterShutdownConfig:
- if shutdownConfig, ok := conf.(*config.ShutdownConfig); ok {
- f.shutdownConfig = shutdownConfig
- return
+ switch conf := conf.(type) {
Review Comment:
ct := conf.(type)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
