Alanxtl commented on code in PR #2906: URL: https://github.com/apache/dubbo-go/pull/2906#discussion_r2119057467
########## graceful_shutdown/shutdown.go: ########## @@ -49,8 +50,8 @@ const ( ) var ( - initOnce sync.Once - compatShutdown *config.ShutdownConfig + initOnce sync.Once + shutdown *global.ShutdownConfig Review Comment: the shutdown transfered in Init() is `*global.ShutdownConfig`, what i've done here is to reduce the convertation in line 66. And the `compatShutdownConfig` used in line 66 is identically the same as `compatShutdownConfig` declared in `compat.go`, which is redundant. So in this line I changed it to `*global.ShutdownConfig`, so that I can delete the redundant `compatShutdownConfig` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
