juzi214032 commented on a change in pull request #9613:
URL: https://github.com/apache/dubbo/pull/9613#discussion_r790289366
##########
File path:
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/ForkingClusterInvoker.java
##########
@@ -96,7 +93,7 @@ public Result doInvoke(final Invocation invocation,
List<Invoker<T>> invokers, L
});
}
try {
- Object ret = ref.poll(timeout, TimeUnit.MILLISECONDS);
+ Object ret = ref.poll(Integer.MAX_VALUE,
TimeUnit.MILLISECONDS);
Review comment:
I don't think it's reasonable to make the queue wait indefinitely, which
may generate some unknown exceptions, and a reasonable way would be to reverse
the relevant exception message when the ret is empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
