codeimport commented on a change in pull request #9613:
URL: https://github.com/apache/dubbo/pull/9613#discussion_r790387649
##########
File path:
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/ForkingClusterInvoker.java
##########
@@ -96,7 +93,7 @@ public Result doInvoke(final Invocation invocation,
List<Invoker<T>> invokers, L
});
}
try {
- Object ret = ref.poll(timeout, TimeUnit.MILLISECONDS);
+ Object ret = ref.poll(Integer.MAX_VALUE,
TimeUnit.MILLISECONDS);
Review comment:
Yes，if poll method use the same timeout with the provider，when provider
timeout the poll method used in forkingClusterInvoker will time out earlier
than the provider side, so it will get null from the queue and throw NPE in the
subsequent process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
